Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package url for grpc integration #3563

Merged
merged 6 commits into from
Jun 30, 2023
Merged

Fix package url for grpc integration #3563

merged 6 commits into from
Jun 30, 2023

Conversation

jaeheonji
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

When I followed the example code exactly, I saw an error in the application because of the wrong import path.

I'm not sure about the history, but it seems that the stub code of protobuf has been moved from dapr/dapr to dapr/go-sdk.
Since UnimplementedAppCallbackServer is imported from dapr/go-sdk, common should also be imported from same package.

@jaeheonji jaeheonji requested review from a team as code owners June 17, 2023 14:28
@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jun 27, 2023
@yaron2 yaron2 merged commit 8781fa1 into dapr:v1.11 Jun 30, 2023
@yaron2
Copy link
Member

yaron2 commented Jun 30, 2023

Thanks for your contribution!

@yaron2 yaron2 added this to the 1.12 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants